docker: pin validate fallback runs compose with no -f when the chooser answers null #51
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up from the approving review on #48 (inline nit, pre-existing).
Reachable when
answeringContaineranswers null (a project of nothing but one-offs) or the answering container has noconfig_files(e.g. a hand-run container carrying only the project label): in the pin action's validate fallback (packages/modules/docker/backend/actions.ts, around line 513)filesis[], so the fallback runsdocker host-side compose config -qwith no-fat all. Compose then resolves whatever sits in the host CWD, or dies withno configuration file provided: not found. The edits are rolled back either way, but the operator gets an error about the wrong thing.The container-pin action's fallback already does the better thing —
edits.flatMap((e) => ["-f", e.file]), i.e. the files this run actually patched.patchesis in scope at the stack-pin site and holds exactly that.Source: #48 (comment)