module-storage: the key-list cap is untested — dropping KEY_LIST_LIMIT keeps the suite green #52

New issue

Open

opened 2026-08-21 23:21:15 +02:00 by julian · 0 comments

julian commented

2026-08-21 23:21:15 +02:00

Owner

Follow-up (a) from the approving review on #46.

Nothing pins the cap on GET /system/module-storage/:module. Replacing the route's host.moduleStorage.list(module, KEY_LIST_LIMIT) (packages/server/src/app.ts:354) with an unbounded list(module) — the exact round-3 shape — still passes 131/131. storage_test.ts has no limit case either, so both the SQL bound and the total that reports what it cut are the one part of the change with no test.

Closing it: kv.list("m", 2) over five rows in storage_test.ts, plus a route assertion where total > keys.length (today total is only asserted in the uncapped case).

Source: #46 (comment)

Follow-up (a) from the approving review on #46. Nothing pins the cap on `GET /system/module-storage/:module`. Replacing the route's `host.moduleStorage.list(module, KEY_LIST_LIMIT)` (`packages/server/src/app.ts:354`) with an unbounded `list(module)` — the exact round-3 shape — still passes 131/131. `storage_test.ts` has no `limit` case either, so both the SQL bound and the `total` that reports what it cut are the one part of the change with no test. Closing it: `kv.list("m", 2)` over five rows in `storage_test.ts`, plus a route assertion where `total > keys.length` (today `total` is only asserted in the uncapped case). Source: https://git.imhof.cloud/OpsDeck/core/pulls/46#issuecomment-1032

No labels

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

OpsDeck/core#52

No description provided.

Rows
Columns