deno.sh: prune warning blames the daemon when the tag simply vanished in the concurrent-prune race #56

New issue

Open

opened 2026-08-21 23:21:42 +02:00 by julian · 0 comments

julian commented

2026-08-21 23:21:42 +02:00

Owner

Nit from the approving review on #42 (wording, not behaviour).

last=$(docker image inspect …) || last= funnels every non-zero inspect into the "no LastTagTime from this daemon" branch — but No such image exits 1 the same way a missing template field does. The concurrent-prune race the comment at .forgejo/deno.sh:104 names produces exactly that: the other run untags between this run's docker images and its inspect, and the log then accuses the daemon.

Fix: reword to "could not read LastTagTime for $stale; not pruning it", which covers both causes and stays true.

Source: #42 (comment) (first nit).

Nit from the approving review on #42 (wording, not behaviour). `last=$(docker image inspect …) || last=` funnels every non-zero inspect into the "no LastTagTime from this daemon" branch — but `No such image` exits 1 the same way a missing template field does. The concurrent-prune race the comment at `.forgejo/deno.sh:104` names produces exactly that: the other run untags between this run's `docker images` and its `inspect`, and the log then accuses the daemon. Fix: reword to "could not read LastTagTime for `$stale`; not pruning it", which covers both causes and stays true. Source: https://git.imhof.cloud/OpsDeck/core/pulls/42#issuecomment-1031 (first nit).

No labels

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

OpsDeck/core#56

No description provided.

Rows
Columns